Skip to content

Conversation

Copy link

Copilot AI commented Dec 4, 2025

  • Rebased branch on current main to resolve merge conflicts
  • Main branch had already removed time_point_thresh_nopol function
  • Applied changes to support both rising and falling crossings in time_point_thresh
  • Applied changes to interpolated_time_point_thresh
  • Updated docstrings to reflect bidirectional crossing detection
  • Added comprehensive test coverage for negative polarity waveforms
  • All tests pass (3 tests in test_time_point_thresh.py)
  • Pre-commit checks pass

Changes

The branch has been rebased on the current main branch, which had diverged significantly. The main branch had already removed the time_point_thresh_nopol function, so the changes now focus on enhancing the main time_point_thresh and interpolated_time_point_thresh functions to support both positive and negative polarity waveforms by detecting crossings in both directions (rising and falling).

Original prompt

Change the time_point_thresh processor such that it does not require a positve waveform polarity. Make sure that it also accepts negative polarities. It's important to still require a crossing, though, so a simple comparison of the current waveform value with threshold will not suffice.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update time_point_thresh processor for negative polarity Support negative polarity waveforms in time_point_thresh Dec 4, 2025
Copilot AI requested a review from cVogl97 December 4, 2025 15:37
Copy link
Owner

@cVogl97 cVogl97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original branch changed while you were working. Take a look and modify your code such that there are no merge conflicts anymore.

Copy link
Author

Copilot AI commented Dec 4, 2025

The original branch changed while you were working. Take a look and modify your code such that there are no merge conflicts anymore.

Resolved merge conflicts by rebasing on main (commit 36bdeed). The main branch had removed time_point_thresh_nopol, so the changes now enhance the main time_point_thresh function to support both rising and falling crossings. All tests pass.

@cVogl97
Copy link
Owner

cVogl97 commented Dec 4, 2025

Let's solve this in a fresh PR

@cVogl97 cVogl97 closed this Dec 4, 2025
@cVogl97 cVogl97 deleted the copilot/modify-time-point-thresh-processor branch December 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants