Support negative polarity waveforms in time_point_thresh #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The branch has been rebased on the current main branch, which had diverged significantly. The main branch had already removed the
time_point_thresh_nopolfunction, so the changes now focus on enhancing the maintime_point_threshandinterpolated_time_point_threshfunctions to support both positive and negative polarity waveforms by detecting crossings in both directions (rising and falling).Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.