Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for frequency in multi-study view #11331

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

eugeniomazzone
Copy link

Fix #10967

Describe changes proposed in this pull request:

  • Function AlterationCountServiceUtil.setupAlterationGeneCountsMap now initialize the profiledCases to 0.
  • Added an additional piece of code (after above function is called) in AlterationCountServiceImpl to update the number of profiled samples with the correct one, for each study and each gene.

After the fix, the frequency displayed on the multi-study view appear to be correct as it's 23.8% as expected instead of 100%.

Before fix:
Before1
Before2

After fix:
After1
After2

@zeynepkaragoz
Copy link
Contributor

@inodb Eugenio worked on fixing one of the open issues, could you point us to some potential reviewers please?

@eugeniomazzone eugeniomazzone marked this pull request as ready for review January 13, 2025 16:20
@inodb inodb requested review from alisman and haynescd January 13, 2025 19:55
@inodb
Copy link
Member

inodb commented Jan 13, 2025

@haynescd @alisman this is a fix in legacy code for determining alteration frequency in multi-study query. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation count in combined studies with genepanels seems to be incorrect
3 participants