Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting it running on Windows #87

Merged
merged 9 commits into from
Mar 5, 2025
Merged

Getting it running on Windows #87

merged 9 commits into from
Mar 5, 2025

Conversation

d-krupke
Copy link
Collaborator

Just to trigger the test CI and not waste everything on the expensive deploy CI.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (4059b3f) to head (555ba5a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   99.15%   99.28%   +0.12%     
==========================================
  Files          30       30              
  Lines        1545     1532      -13     
==========================================
- Hits         1532     1521      -11     
+ Misses         13       11       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-krupke
Copy link
Collaborator Author

Not sure about the codecov CI that failed. Otherwise, it should be ready for merge. I had to do some changes to make it compile with MSVC.

@d-krupke
Copy link
Collaborator Author

d-krupke commented Mar 5, 2025

Just in case it got forgotten: This PR should be ready to merge as the CI is now running.

Copy link
Owner

@c4v4 c4v4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the delay, I forgot to submit the comments

@c4v4
Copy link
Owner

c4v4 commented Mar 5, 2025

I should have fixed the ambiguity problems with std::size and std::min/max.
They were remnants of older versions that needed them, but they are useless now.

Copy link
Owner

@c4v4 c4v4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, even better than before to be fair.
Thanks for the work!!

@c4v4 c4v4 merged commit 6cb63d0 into main Mar 5, 2025
8 checks passed
@c4v4 c4v4 deleted the deploypypi branch March 5, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants