-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting it running on Windows #87
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 99.15% 99.28% +0.12%
==========================================
Files 30 30
Lines 1545 1532 -13
==========================================
- Hits 1532 1521 -11
+ Misses 13 11 -2 ☔ View full report in Codecov by Sentry. |
Not sure about the codecov CI that failed. Otherwise, it should be ready for merge. I had to do some changes to make it compile with MSVC. |
Just in case it got forgotten: This PR should be ready to merge as the CI is now running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry for the delay, I forgot to submit the comments
I should have fixed the ambiguity problems with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, even better than before to be fair.
Thanks for the work!!
Just to trigger the test CI and not waste everything on the expensive deploy CI.