Skip to content

Block Internal Users #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nafiz1001 wants to merge 2 commits into
base: qc
Choose a base branch
from
Draft

Block Internal Users #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0890f9b
reject internal users
nafiz1001 Jul 16, 2024
1568d55
reject internal users at the middleware level
nafiz1001 Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion triton-server/src/magic/magic_middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,13 @@ const magicAuthMiddleware = asyncHandler(
// User token is no longer valid. Flush the session info and force a new login.
req.session.credentials = undefined
req.session.userDetails = undefined

if (userDetails.accountType === "Internal") {
res.status(403).send(
"Internal users are not allowed to use Triton.",
)
next(Error("Internal users are not allowed to use Triton."))
}
}
}

Expand Down Expand Up @@ -106,12 +113,19 @@ const magicCallbackHandler = asyncHandler(async (req, res, next) => {
// Verify that the user is still logged in with the token.
const isAuthenticated = await isUserAuthenticated(userId, token)
if (!isAuthenticated) {
throw Error("Not authenticated")
res.status(401).send("Not Authorized")
next(Error("Not Authorized"))
}

// Ask Magic for the user's details.
const userDetails = await getUserDetails(userId, token)

// Do not allow internal users
if (userDetails.accountType === "Internal") {
res.status(403).send("Internal users are not allowed to use Triton.")
next(Error("Internal users are not allowed to use Triton."))
}

// Store the user details and their login credentials in the session.
// We need the user id and token because triton has to check if the user is
// still logged in before every request it makes to magic on behalf of the user.
Expand Down