Fix LabWork page layout and create new PR #1143
Conversation
nabalma
changed the title
|
You should close the PR #1142 |
|
Yes, I will. |
|
You may want to do a rebase on |
|
To make it not too wide, I'd overwrite |
nabalma
force-pushed
the
labwork-page-taking-half-page-v3
branch
from
439e9f8 to
4b80bb4
Compare
| <AppPageHeader title="Lab Work" /> | ||
|
|
||
| <PageContent loading={loading} style={{maxWidth: '50rem'} as any}> | ||
| <PageContent loading={loading} /*style={{maxWidth: '50rem'} as any}*/> |
There was a problem hiding this comment.
When removing code, just remove the code completely. Otherwise we'll end up with "dead" code all over the place.
This solves the scroll bar issue, but underscores the initial intent. The numbers are too far from the protocol name to be seen in a single glance. It forces a lateral scan .
Maybe we can apply the original maxWidth to the child components and still have a full page content scroll bar ?
There was a problem hiding this comment.
Noted. @UlysseFG . I Will completely remove the comment and also explore the second solution of the child component ... Many thanks,
…he potocols items and numbers a are close
|
Second fix proposed : The comments have been removed. |
3 participants
This PR replaces the previous incorrect PR (#1142), which will be closed.
Amendment:
The content page of the LabworkOverview component had a
maxWidth: '50rem'style set on the PageContent component. I commented it out.