Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personalized theme #44

Open
ecrin4102 opened this issue Oct 13, 2023 · 1 comment
Open

Personalized theme #44

ecrin4102 opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement New feature or request mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next

Comments

@ecrin4102
Copy link

ecrin4102 commented Oct 13, 2023 •
edited
Loading

Font, color and etc are statics and can't be changed by the user. An easy improvement could be simply to add some settings in the Theme Panel, like the font, and the color of titles.
@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Oct 13, 2023
@ecrin4102 ecrin4102 changed the title Personelized theme Personalized theme Oct 13, 2023
@c3er
Copy link
Owner

c3er commented Oct 13, 2023

Thanks for filing this issue!

Your suggestion doesn't look so easy to me. I see following problems spontaneously:

  • Gathering the actual detailed settings to add for this feature. You may help me with that. 🙂
  • Currently, the whole appearance is hard coded. It will probably take some effort to change that. Also, the sub optimal architecture doesn't help with that
  • Should color settings be a "custom theme"? Or should it be possible to change the appearance of light and dark theme independently? The former would be easier (I think) but still not trivial.

It will take some time anyway, because I have currently not much time and energy for this hobby project.

@c3er c3er added enhancement New feature or request and removed needs reaction Owner didn't react to this issue yet labels Oct 13, 2023
@c3er c3er mentioned this issue Feb 10, 2024
Open
@c3er c3er added the mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecrin4102 @c3er