Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: tabs for opened documents #49

Open
ElektroStudios opened this issue Feb 9, 2024 · 4 comments
Open

Feature Request: tabs for opened documents #49

ElektroStudios opened this issue Feb 9, 2024 · 4 comments
Labels
enhancement New feature or request mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next

Comments

@ElektroStudios
Copy link

ElektroStudios commented Feb 9, 2024

I know you don't have much time, but I would like to know if it would be possible to implement tabs to be able to open multiple documents within the same instance of the program.

This is what I mean for tabs:

Currently, when I drop an MD file into the Markdown View window, the program displays a dialog box asking if I want to load the document into that window, or to open a new, separated window. The ideal behavior in my opinion would be that when selecting to load the document in the same window, a tab should be added with the content of the new loaded document, instead of replacing the rendered content of the previously loaded file.

And then a new option "Open file in a new tab" could be added here:

In fact, if tabs could be implemented, I think there would no longer be a good reason to want to open a new window separately to open/load new MD documents. Although there may always be someone who prefers to have multiple windows floating around, I think tabs would make it a lot simpler.


This may be off topic, but I just want to say that your Markdown View program is the fastest and most responsive (among other things when scrolling the window) when loading tables with thousands of items. I've tried almost every option to reach that conclusion, from Markdown Monster, Markdown Pad, MarkText and more.

Congratulations for your hard work, and thank you for sharing this program.

@github-actions github-actions bot added the needs reaction Owner didn't react to this issue yet label Feb 9, 2024
@c3er
Copy link
Owner

c3er commented Feb 10, 2024

Thanks again for taking time to file this issue!

That's a pretty big change and I'm afraid, I have to let open this issue a while, like #44. I'm currently doing a big refactoring and such a major change of this tool should be made after this refactoring, using the new architecture.

@c3er c3er added enhancement New feature or request and removed needs reaction Owner didn't react to this issue yet labels Feb 10, 2024
@c3er
Copy link
Owner

c3er commented Feb 10, 2024

This may be off topic, but I just want to say that your Markdown View program is the fastest and most responsive (among other things when scrolling the window) when loading tables with thousands of items. I've tried almost every option to reach that conclusion, from Markdown Monster, Markdown Pad, MarkText and more.

This surprises me, since the architecture is really sub optimal and rendering can be improved two to three times, if I didn't make some mistakes at the beginning that are very difficult to fix. But maybe, the other tools have an even worse architecture😅

@ElektroStudios
Copy link
Author

ElektroStudios commented Feb 10, 2024

This surprises me, since the architecture is really sub optimal and rendering can be improved two to three times, if I didn't make some mistakes at the beginning that are very difficult to fix. But maybe, the other tools have an even worse architecture😅

Want to know what surprises me?, that mainstream choices and paid software like Markdown Monster will not allow the user to load a Markdown file with a table containing around 6000 elements, it literally warns about the amount of elements and will not render it, but your open-source program will render it, It's pretty fast doing so (well, I didn't measured the time but it feels like the fastest one), and the UI is very responsive when scrolling through the content of the rendered table. I cannot say the same for any of the other programs I've tried.

Maybe it will be because your program does not have text editing functionalities that decrease response time, and that is what makes this program so unique and good, because It only serves as a Markdown file viewer and that makes it faster than any specialized text editor.

I wish I had experience with Electron to try to collaborate, but I have not, so I limit myself to giving my critical opinion, some suggestions, and showing gratitude.

I will look forward to the next version of the program to see the improvements.
All the best.

@c3er c3er added the mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next label Apr 16, 2024
@zenyum
Copy link

zenyum commented Oct 15, 2024

A btw big thanks. A fast and simple markdown _view_er is quit a life essential.

This may be off topic, but I just want to say that your Markdown View program is the fastest and most responsive (among other things when scrolling the window) when loading tables with thousands of items. I've tried almost every option to reach that conclusion, from Markdown Monster, Markdown Pad, MarkText and more.

This surprises me, since the architecture is really sub optimal and rendering can be improved two to three times, if I didn't make some mistakes at the beginning that are very difficult to fix. But maybe, the other tools have an even worse architecture😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mdview next Next major version after big refactoring. See https://github.com/c3er/mdview-next
Projects
None yet
Development

No branches or pull requests

3 participants