Calendar #43
Open
Calendar #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-harding
commented
May 5, 2022
| const router = express.Router(); | ||
|
|
||
| const mkRequestLogin = (res: express.Response) => async () => { | ||
| res.status(403).send('Not logged in'); |
|
|
||
| res.type('text/calendar; charset=UTF-8'); | ||
|
|
||
| const cal = ical({ name: 'Strava activities' }); |
There was a problem hiding this comment.
- Add proper caching of ical (only fetch new activities, e.g. from past week)
- Clear old caches after certain time
- Handle logout through GUI
- Add link to GUI
|
|
||
| for await (const activity of eagerIterator(strava.getStravaActivities())) { | ||
| const startTime = moment(activity.start_date).tz(activity.timezone.split(' ')[1]); | ||
| const location = activity.start_latlng.join(', '); |
There was a problem hiding this comment.
- Consider geocoding here
c-harding
force-pushed
the
calendar
branch
2 times, most recently
from
094f89f to
d9215dd
Compare
c-harding
force-pushed
the
calendar
branch
5 times, most recently
from
56c2872 to
dbc9936
Compare
|
A UI could be provided with two buttons to launch a calendar app, or to copy the ICAL link allowing the user choice over which they use. This allows google calendar users to add it both on mobile and windows very easily |
c-harding
force-pushed
the
calendar
branch
5 times, most recently
from
4eda375 to
930fe98
Compare
c-harding
force-pushed
the
new-sidebar
branch
from
7c7c144 to
fa8cb09
Compare
c-harding
force-pushed
the
new-sidebar
branch
from
fa8cb09 to
4236ca2
Compare
c-harding
force-pushed
the
new-sidebar
branch
from
4236ca2 to
362d8a9
Compare
c-harding
force-pushed
the
calendar
branch
4 times, most recently
from
98f255d to
edacd73
Compare
c-harding
force-pushed
the
calendar
branch
6 times, most recently
from
32b43f8 to
fc010a8
Compare
c-harding
force-pushed
the
calendar
branch
4 times, most recently
from
ae5802a to
fbf0534
Compare
c-harding
force-pushed
the
calendar
branch
4 times, most recently
from
1cc17e2 to
52818d2
Compare
c-harding
force-pushed
the
calendar
branch
2 times, most recently
from
30d6682 to
6a9ce7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint for serving an ical calendar containing all activities