The Great Renaming, Chapter 11: Add QCheck.noshrink #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to close up the renaming adventure, I've gone over the "generator returning" shrink combinators.
Here's a status:
Observations:
QCheck.Genhas no shrinking, so these make little sense thereset_shrinksignature is slightly different, but so is classical shrinking inQCheckvs. integrated shrinking inQCheck2no_shrinkcould be easily added toQCheck.arbitraryfor consistencyThis PR thus does the latter as it is a small convenience function.
While wanting to write a test for it, I was pleased to notice that we already had one 🎉 so I updated that one instead.
The update also documents that
no_shrinkis easier to write thanset_shrink Shrink.nil... 🙂