remove trace_id entirely, use meta-maps in more places
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The direct use of span_id+trace_id in OTEL is a bad idea, and it makes little sense in other collectors. In the end, `span` should be thought of as an opaque key only the collector understands, and a meta-map should be carried around for the collector to stash additional info such as a (8B, 16B, ...) trace ID or other information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct use of span_id+trace_id in OTEL is a bad idea, and it makes
little sense in other collectors. In the end,
spanshould be thoughtof as an opaque key only the collector understands, and a meta-map
should be carried around for the collector to stash additional info such
as a (8B, 16B, ...) trace ID or other information.