Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(moonbit): eliminate warning and fix ownership #1058

Merged

Conversation

peter-jerry-ye
Copy link
Contributor

This PR eliminates all the warnings of the generated code and use --deny-warn option in test to enforce this.

This PR also adds build process to the test instead of just checking.

This PR fixes an issue with ownership, which may occur when exporting a data structure and being freed later.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Sep 25, 2024
Merged via the queue into bytecodealliance:main with commit 1718dfb Sep 25, 2024
28 checks passed
@peter-jerry-ye peter-jerry-ye deleted the moonbit-eliminate-warning branch October 14, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants