pulley: Initial scaffold of SIMD support #9820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
cfallin and
fitzgen
and removed request for
a team
alexcrichton
force-pushed
the
pulley-simd
branch
from
3436c7c to
9228b69
Compare
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
force-pushed
the
pulley-simd
branch
from
9228b69 to
b4a0186
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexcrichton
force-pushed
the
pulley-simd
branch
from
ddd0221 to
afe050f
Compare
|
@fitzgen if you wouldn't mind taking a look at the second commit here. The CI failure was due to endianness failures on s390x because big-endian loads/stores of vectors aren't implemented in Pulley. I personally find it easiest to sidestep the question entirely, so I've redefined wasm globals to be little-endian instead of big-endian, updated some accessors, and then additionally updated pulley stack loads/stores of vectors to be in little-endian. I also needed to implement |
This commit fills out some of the initial infrastructure necessary for supporting the SIMD proposal to WebAssembly in the Pulley interpreter, namely 128-bit simd. The `VRegVal` union has been filled out with various types, endianness questions are settled, and initial implementations of a suite of opcodes are added to get a basic set of tests working throughout the backend. cc bytecodealliance#9783
* Change wasm `global`s to store `v128` in little-endian format. * Change pulley stack loads/stores to work with vectors in little-endian format.
alexcrichton
force-pushed
the
pulley-simd
branch
from
afe050f to
00d5e27
Compare
github-actions
bot
added
the
wasmtime:api
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fills out some of the initial infrastructure necessary for
supporting the SIMD proposal to WebAssembly in the Pulley interpreter,
namely 128-bit simd. The
VRegValunion has been filled out withvarious types, endianness questions are settled, and initial
implementations of a suite of opcodes are added to get a basic set of
tests working throughout the backend.
cc #9783