Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulley: Update how tests are expected to fail or pass #9786

Merged

Conversation

alexcrichton
Copy link
Member

With enough basic support here and there switch the listing of tests for
Pulley from known-passing to known-failing instead. This trims the list
of unsupported features to just those that are truly unsupported and
then additionally rewrites the list of tests to be an exhasutive list of
unsupported tests instead of a list of supported tests.

This should make it a bit easier to track the progress as now pulley is
"complete" once this list is empty.

cc #9783

@alexcrichton alexcrichton requested review from a team as code owners December 11, 2024 15:30
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team December 11, 2024 15:30
@alexcrichton
Copy link
Member Author

Note that this is currently based on #9785 which is itself based on #9780

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

With enough basic support here and there switch the listing of tests for
Pulley from known-passing to known-failing instead. This trims the list
of unsupported features to just those that are truly unsupported and
then additionally rewrites the list of tests to be an exhasutive list of
unsupported tests instead of a list of supported tests.

This should make it a bit easier to track the progress as now pulley is
"complete" once this list is empty.
@alexcrichton alexcrichton force-pushed the pulley-change-pass-fail branch from 3150619 to ad66f51 Compare December 11, 2024 16:52
@alexcrichton alexcrichton added this pull request to the merge queue Dec 11, 2024
Merged via the queue into bytecodealliance:main with commit 461a72e Dec 11, 2024
43 checks passed
@alexcrichton alexcrichton deleted the pulley-change-pass-fail branch December 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants