-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows on ARM64 #268
Conversation
(Looks like the CI has been failing for a couple days unrelated to my change) |
Actually I see in the runner image used for Windows (https://github.com/actions/runner-images/blob/win22/20250127.1/images/windows/Windows2022-Readme.md) that GCC is included. So I'll revert that change to using 'clang' on Windows, install that locally, and try again. |
With the latest couple of commits and with 'gcc' installed locally via MSYS2 (as per the Windows CI build server), all tests are passing and the wheel is building successfully on my machine! I've updated the main.yml with what is hopefully the prerequisite magic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
CI failures here will get fixed in bytecodealliance/actions#15 (or so I'm hoping), so I'll take care of the CI bits for this in the near future. |
Ok I think that CI failure might be legitimate? |
Ugh. As well as platform.machine() not matching on arm64, looks like Windows has a different value to Linux/Mac for x64 as well (on Mac and Linux it's
I've just realized that this is also going to hit the same problem we have in our I'll push a commit shortly that fixes x64 on Windows and removes Windows aarch64 from the pipeline until you comment on the test coverage question. Thanks! |
I noticed none of the tests run on arm64 for any platforms - so there was nothing to remove and it seems in line. CI is green now! As extra validation, I copied/installed the wheel from the CI build to my Windows ARM64 machine into a clean venv and ran a few of the scripts from under ./examples and they all run fine. |
Thanks for confirming! And yeah we could probably set up and arm64 runner now that ubuntu-arm64 images exist on github actions, but alas I don't think there are windows arm64 images just yet... |
This is for issue #247 . Putting up for early review, but some testing on other platforms and a couple questions remain.