Support protocol = "http" in OCI registry config
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
oci-allow-http-protocol
branch
from
c5dd332 to
6ad797f
Compare
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
oci-allow-http-protocol
branch
from
6ad797f to
987c078
Compare
itowlson
commented
May 22, 2024
| .as_ref() | ||
| .is_some_and(|cfg| cfg.platform_resolver.is_some()) | ||
| { | ||
| if client_config.platform_resolver.is_some() { | ||
| Error::InvalidConfig(anyhow::anyhow!( |
There was a problem hiding this comment.
I was a bit puzzled by this line. It looks like it constructs the Error and then drops it rather than returning it. But when I tried changing it to return the Error, the CI failed with this error message. So I've left it along but I feel like I'm missing something...!
lann
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful/required for local registries e.g.