Create the output directory if it does not exist (#118) #141

chikoski · 2024-12-29T00:58:58Z

This PR is a fix for issue #118. With this fix, the get command creates the directory specified by the -o option if the specified directory does not exist.

For example, the following command creates the wit directory and saves the wasi:[email protected] in it:

$ wkg get -o wit/ wasi:http0.2.0

…lliance#118)

thomastaylor312

Thanks for adding this! Just one small change needed

thomastaylor312 · 2024-12-30T18:05:24Z

crates/wkg/src/main.rs

@@ -1,4 +1,4 @@
-use std::{io::Seek, path::PathBuf};
+use std::{fs, io::Seek, path::PathBuf};


Can you please swap out to use tokio::fs since the function is an async one?

Change to create the output directory if it does not exist (bytecodea…

19c02e2

…lliance#118)

thomastaylor312 requested changes Dec 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create the output directory if it does not exist (#118) #141

Create the output directory if it does not exist (#118) #141

chikoski commented Dec 29, 2024

thomastaylor312 left a comment

thomastaylor312 Dec 30, 2024

		@@ -1,4 +1,4 @@
		use std::{io::Seek, path::PathBuf};
		use std::{fs, io::Seek, path::PathBuf};

Create the output directory if it does not exist (#118) #141

Are you sure you want to change the base?

Create the output directory if it does not exist (#118) #141

Conversation

chikoski commented Dec 29, 2024

thomastaylor312 left a comment

Choose a reason for hiding this comment

thomastaylor312 Dec 30, 2024

Choose a reason for hiding this comment