Adding additional text around the test requirement for code.

[woodsmc]

Speaking to @lum1n0us I was suggesting that we change our process for accepting code contributions to require testing, unless there is a good reason not to have them. At the moment supplying a test is optional.

I suggest we should change this to be a requirement -> if you change code supply a test. We could have contributors point to existing tests which cover their contribution, or supply new testing. If the code change is super tiny, like formatting, or variable name change, then code's existing functionality is testing with the existing tests.

If the code contribution is larger or affects logic, fixes a bug etc, then we should require a test. In the case of a bug, a test case to reproduce the issue, and the fix, so we can re-run the test case to show the issue cannot be reproduced.

This is my first attempt at the text for this, it's a little all over the place. But it's a start. I'd welcome your thoughts on the idea.

[woodsmc]

Yes, and following these guides, I'd have to add :

This is a minor change explain the change, and as such is except from addition test contribution.

Yes, the irony of me not adding this disclaimer is high,... ;p

[lum1n0us]

LGTM. hope to hear others' opinions.

[loganek]

100% agree. I wonder if we should also update our PR template to include the checkbox about testing?

[TianlongLiang]

Good idea 👍