Skip to content

Raise wasi-sdk to 25 and wabt to 1.0.37 #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

lum1n0us
Copy link
Collaborator

based on #4180

@lum1n0us lum1n0us marked this pull request as ready for review April 10, 2025 04:08
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

@lum1n0us lum1n0us force-pushed the fix/action_install_wasi_wabt branch from 370bb9d to a6829f9 Compare April 15, 2025 04:55
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Refactor CI workflow to install WASI-SDK and WABT from a composite action
- Use ExternalProject to bring wasm-apps for few samples. file/ wasi-threads/
- Refactor sample build and test steps in SGX compilation workflow for improved clarity and efficiency (workaround)
@lum1n0us lum1n0us force-pushed the fix/action_install_wasi_wabt branch from f884d8c to 177f52e Compare April 17, 2025 07:18
@lum1n0us lum1n0us merged commit 8f8c560 into bytecodealliance:main Apr 17, 2025
657 checks passed
@lum1n0us lum1n0us deleted the fix/action_install_wasi_wabt branch April 17, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants