Merge pull request #267 from bytecodealliance/ydnar/issue-264

wit/bindgen: correctly cast to named Go bool types when lowering

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+- [#264](https://github.com/bytecodealliance/go-modules/issues/264): fix lowering for imported functions that return named `bool` types.
+
 ## [v0.4.1] — 2024-12-09
 
 ### Added

testdata/issues/issue264.wit

@@ -0,0 +1,10 @@
+package issues:issue264;
+
+interface i {
+	type boolean = bool;
+	f: func() -> boolean;
+}
+
+world w {
+	import i;
+}

testdata/issues/issue264.wit.json

@@ -0,0 +1,59 @@
+{
+  "worlds": [
+    {
+      "name": "w",
+      "imports": {
+        "interface-0": {
+          "interface": {
+            "id": 0
+          }
+        }
+      },
+      "exports": {},
+      "package": 0
+    }
+  ],
+  "interfaces": [
+    {
+      "name": "i",
+      "types": {
+        "boolean": 0
+      },
+      "functions": {
+        "f": {
+          "name": "f",
+          "kind": "freestanding",
+          "params": [],
+          "results": [
+            {
+              "type": 0
+            }
+          ]
+        }
+      },
+      "package": 0
+    }
+  ],
+  "types": [
+    {
+      "name": "boolean",
+      "kind": {
+        "type": "bool"
+      },
+      "owner": {
+        "interface": 0
+      }
+    }
+  ],
+  "packages": [
+    {
+      "name": "issues:issue264",
+      "interfaces": {
+        "i": 0
+      },
+      "worlds": {
+        "w": 0
+      }
+    }
+  ]
+}

testdata/issues/issue264.wit.json.golden.wit

@@ -0,0 +1,10 @@
+package issues:issue264;
+
+interface i {
+	type boolean = bool;
+	f: func() -> boolean;
+}
+
+world w {
+	import i;
+}

wit/bindgen/generator.go

@@ -1456,7 +1456,7 @@ func (g *generator) cast(file *gen.File, dir wit.Direction, from, to wit.Type, i
 	if t != nil {
 		return g.cmCall(file, goKind(from)+"To"+goKind(to)+"["+g.typeRep(file, dir, t)+"]", input)
 	}
-	return g.cmCall(file, goKind(from)+"To"+goKind(to), input)
+	return "(" + g.typeRep(file, dir, to) + ")(" + g.cmCall(file, goKind(from)+"To"+goKind(to), input) + ")"
 }
 
 func goKind(t wit.Node) string {