#36 Fix the modal display when there is no category with flavor#41
Open
minhduchoang195 wants to merge 1 commit intobycs-lp:mainfrom
Open
#36 Fix the modal display when there is no category with flavor#41minhduchoang195 wants to merge 1 commit intobycs-lp:mainfrom
minhduchoang195 wants to merge 1 commit intobycs-lp:mainfrom
Conversation
Contributor
|
Hi @minhduchoang195 , |
…category with flavors is present
minhduchoang195
force-pushed
the
#36-fix_first_category_tab_on_first_open
branch
from
9e7d2ce to
8b9be20
Compare
Author
I have removed the changes in the minimized JS files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main reason: When the element modal is initialized, the first virtual click is triggered on the first category tab. This click should hide all buttons from other categories. The first tab can be the first category with or without flavors. However, if there is no category with flavors, the display order of the first category with flavors is still required. Therefore, the first virtual click cannot be executed in this scenario, and all buttons from all categories are displayed.
Resolution: Ensure that the list of categories with flavors is not empty before comparing display orders.