Skip to content

MBS-8117: fix draghomes height to prevent overflow #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbs-LP wants to merge 3 commits into
base: master-forked
Choose a base branch
from
Open

MBS-8117: fix draghomes height to prevent overflow #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e889b85
MBS-5702: fix privacy provider
Sep 3, 2021
25ee816
MBS-7817: fix deprecated function assertRegExp in phpUnit tests
Jul 25, 2023
a261c06
MBS-8117: fix draghomes height to prevent overflow
Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions classes/privacy/privacy.php → classes/privacy/provider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,11 @@
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.

/**
* Privacy Subsystem implementation for format_tabtopics.
* Privacy Subsystem implementation for qtype_ddmatch.
*
* @package qtype_ddmatch
*
* @author DualCube <admin@dualcube.com>
* @copyright 2007 DualCube (https://dualcube.com)
* @copyright 2007 DualCube (https://dualcube.com)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand All @@ -29,19 +28,25 @@
defined('MOODLE_INTERNAL') || die();

/**
* The format_tabtopics
* Privacy main class.
*
* @package qtype_ddmatch
* @copyright 2019 Amr Hourani <amr.hourani@let.ethz.ch>, 2021 Thomas Ludwig, ISB
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*
*/
class provider implements \core_privacy\local\metadata\null_provider
{
class provider implements \core_privacy\local\metadata\null_provider {

// To provide php 5.6 (33_STABLE) and up support.
use \core_privacy\local\legacy_polyfill;

/**
* Get the language string identifier with the component's language
* file to explain why this plugin stores no data.
*
* @return string
*/
public static function get_reason(): string
{
public static function get_reason() : string {
return 'privacy:metadata';
}
}
4 changes: 2 additions & 2 deletions lang/en/qtype_ddmatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
* The language strings for the match question type.
*
* @package qtype_ddmatch
*
*
* @author DualCube <admin@dualcube.com>
* @copyright 2007 DualCube (https://dualcube.com)
* @copyright 2007 DualCube (https://dualcube.com)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand Down
2 changes: 1 addition & 1 deletion styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ li.matchdrag.copy {
margin: 0;
padding: 0.25rem;
width: 35%;
max-height:23.75rem;
max-height: fit-content;
}

.ddmatch .draghomes li {
Expand Down
6 changes: 3 additions & 3 deletions tests/question_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
*
* @package qtype
* @subpackage ddmatch
*
*
* @author DualCube <admin@dualcube.com>
* @copyright 2007 DualCube (https://dualcube.com)
* @copyright 2007 DualCube (https://dualcube.com)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

Expand Down Expand Up @@ -149,7 +149,7 @@ public function test_get_question_summary() {
$this->assertMatchesRegularExpression('/' . preg_quote($stem, '/') . '/', $qsummary);
}
foreach ($ddmatch->choices as $choice) {
$this->assertRegExp('/' . preg_quote($choice) . '/', $qsummary);
$this->assertMatchesRegularExpression('/' . preg_quote($choice) . '/', $qsummary);
}
}

Expand Down