COMMIT 3: Extracting Logic into Hack Layer#3
COMMIT 3: Extracting Logic into Hack Layer#3awagner wants to merge 1 commit intoMBS-10152-commit2from
Conversation
| @@ -0,0 +1,61 @@ | |||
| # MODIFICATIONS | |||
There was a problem hiding this comment.
I really appreciate this description of the modifications!
|
|
||
| The latest development version can be found on Github: | ||
| https://github.com/lernlink/moodle-mod_individualfeedback | ||
|
|
There was a problem hiding this comment.
I am currently not aware of our contract, but we need to talk about, who is maintaining the plugin in the future.
| ## 4.5 | ||
| ## 4.6.1 | ||
|
|
||
| - As we relay on the same DB structure as before, we DO NOT need to run a /db/upgrade.php script. All we actually only need to do, is to rename / move the current directory. |
There was a problem hiding this comment.
As already mentioned, the code should be able to use existing database tables. So we need to rename the tables: indfeedback_sitecourse_map, indfeedback_completedtmp to your new names: individualfeedback_sitecourse_map, individualfeedback_completedtmp
| } | ||
|
|
||
| // Rename columns in individualfeedback_completedtmp table | ||
| $table = new xmldb_table('individualfeedback_completedtmp'); |
There was a problem hiding this comment.
This will cause an upgrade error, if tables already exist, because according to the former length limit for tablenames of 28 chars, the tablenames are: indfeedback_sitecourse_map, indfeedback_completedtmp.
Therefore the tables must be renamed before the columns are renamed.
| @@ -0,0 +1,290 @@ | |||
| YUI.add('moodle-mod_individualfeedback-dragdrop', function(Y) { | |||
There was a problem hiding this comment.
The feedback module in Moodleversion 4.3.5 (version: 2024100701) does not contain any yui JS. So we expect to get rid of these JS placed in a yui module. Can you please remove and put the code into an amd module, if any of this javascript is necessary.
| $module = $DB->get_record('modules', ['name' => 'individualfeedback']); | ||
| $modules = $DB->get_records('course_modules', | ||
| ['course' => $this->course->id, 'module' => $module->id, 'deletioninprogress' => 0]); | ||
| foreach($modules AS $feedback_item) { |
There was a problem hiding this comment.
Codingstyle: reformat the code along moodle guidelines.
| @@ -0,0 +1,18 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Comment according to moodle guidelines?
|
|
||
| /** | ||
| * Feedback event handler definition. | ||
| * individualfeedback event handler definition. |
There was a problem hiding this comment.
Renamings in commit 2 in general and all affected files.
| * @package mod_individualfeedback | ||
| */ | ||
|
|
||
| defined('MOODLE_INTERNAL') || die(); |
There was a problem hiding this comment.
No subtabs in Moodle 4.5.3 how is this file called?
| @@ -0,0 +1,18 @@ | |||
| function checkstartendgroupitem() { | |||
There was a problem hiding this comment.
Can you please explain the meaning on this file?
2 participants
No description provided.