COMMIT 2: Rename mod_feedback → mod_individualfeedback and smoke-test…#2
COMMIT 2: Rename mod_feedback → mod_individualfeedback and smoke-test…#2awagner wants to merge 1 commit intoMBS-10152-commit1from
Conversation
… installation
Complete migration from Feedback to Individual Feedback plugin including:
- Global rename: mod_feedback → mod_individualfeedback
- Database schema updates: all table and column names updated
- All code references, SQL queries, and object properties updated
- File structure: all files and classes properly renamed
- Language strings: updated for clear plugin distinction ('Individual Feedback')
- Backup/restore: fully functional with new naming convention
- Form fields and validation: all references corrected
- Constants: FEEDBACK_* → INDIVIDUALFEEDBACK_* throughout
- Upgrade scripts: handles existing installations seamlessly
- All smoke tests pass: installation, question creation, and core functionality verified
Plugin now works independently as 'Individual Feedback' without conflicts with original Feedback plugin.
| @mod @mod_individualfeedback | ||
| Feature: Anonymous feedback | ||
| In order to collect feedbacks | ||
| As an admin |
There was a problem hiding this comment.
This and other behat tests needs to be checked. I assume, that renaming is not complete (for example in line 27)
| DELETE FROM mdl_config_plugins WHERE plugin = 'mod_individualfeedback'; | ||
|
|
||
| -- Remove course modules (this will also remove activities) | ||
| DELETE cm FROM mdl_course_modules cm |
There was a problem hiding this comment.
Using this script is dangerous. It will not properly delete the context for the module, nor the sections assignments. and other stuff related to created modules. Please remove this.
Our expectation is that we will never need this and the upgrade to your version of the plugin will keep the data existing from former feedback submissions.
| @@ -0,0 +1,13 @@ | |||
| -- Alternative approach: Register the existing installation | |||
There was a problem hiding this comment.
Please remove this script, i assume this is used for development, but this is not a proper installation of the plugin.
| defined('MOODLE_INTERNAL') || die(); | ||
|
|
||
| $plugin->version = 2024100701; // The current module version (Date: YYYYMMDDXX). | ||
| $plugin->version = 2024100714; // The current module version (Date: YYYYMMDDXX). |
There was a problem hiding this comment.
Why have you changes the plugin version? I assume you have triggered some upgrade steps during renaming.
It is ok to increase the day digits, but please leave a comment, that describes, from which version you have forked the plugin and why.
2 participants
… installation
Complete migration from Feedback to Individual Feedback plugin including:
Plugin now works independently as 'Individual Feedback' without conflicts with original Feedback plugin.