Conversation
| @@ -0,0 +1,196 @@ | |||
| <?php | |||
There was a problem hiding this comment.
This is a realy weird filename, i can also not find a usage for it. Can you please explain, what this file does?
There was a problem hiding this comment.
We wanted you to add several commits for
• Vendor plugin base (after branch filtering)
• Rename existing mod_feedback plugin to mod_individualfeedback
• Futher commit for you changes to renamed plugin.
So I had rather expected not to find new files after the renaming of forked plugin.
| $return = feedback_ajax_saveitemorder($itemlist, $feedback); | ||
| $return = individualfeedback_ajax_saveitemorder($itemlist, $feedback); | ||
| } | ||
| break; |
There was a problem hiding this comment.
We wanted you to add several commits for
• Vendor plugin base (after branch filtering)
• Rename existing mod_feedback plugin to mod_individualfeedback
• Futher commit for you changes to renamed plugin.
So I had rather expected not to find new files or other modificated lines except renamings after the renaming of forked plugin.
| alert("salvando question group"); | ||
| $itemlist = explode(',', trim($itemorder, ',')); | ||
| if (count($itemlist) > 0) { | ||
| $return = individualfeedback_ajax_saveitemorder($itemlist, $feedback); |
There was a problem hiding this comment.
I you modify existing files of mod_feedback, we want you to do this along out hack guidelines.
| @@ -0,0 +1,64 @@ | |||
| <?php | |||
There was a problem hiding this comment.
These are useful scripts, but we'd expected this to be executed in a unit test, not in a executable cli file.
| @@ -0,0 +1,82 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I can not understand, why this file has been added to this commit. Renaming and adding new files should happen in seperate commits. If this file is not an original file, it should have been added in the next commit.
| /** | ||
| * prints the form so an anonymous user can fill out the individualfeedback on the mainsite | ||
| * | ||
| * @author Andreas Grabs |
There was a problem hiding this comment.
I assume this author is correct?
| * Upgrade helper functions | ||
| * | ||
| * @package mod_individualfeedback | ||
| * @copyright 2016 Marina Glancy |
There was a problem hiding this comment.
New file from Marina 2016? How can this happen.
| public function __construct($action = null, $customdata = null, $method = 'post', $target = '', | ||
| $attributes = null, $editable = true, $ajaxformdata = null) { | ||
| debugging('Class feedback_edit_use_template_form is deprecated. Replaced with dynamic forms.', DEBUG_DEVELOPER); | ||
| $attributes = null, $editable = true, $ajaxformdata = null) { |
There was a problem hiding this comment.
Do not add any whitespace changes to the original code.
| @@ -0,0 +1,18 @@ | |||
| function checkstartendgroupitem() { | |||
There was a problem hiding this comment.
Can you please explain, why there is a *.bak file here?
| $plugin->version = 2024100700; // The current module version (Date: YYYYMMDDXX). | ||
| $plugin->requires = 2024100100; // Requires this Moodle version. | ||
| $plugin->component = 'mod_feedback'; // Full name of the plugin (used for diagnostics) | ||
| $plugin->version = 2025033001; // The current module version (Baseversion Date: 2020070900) |
There was a problem hiding this comment.
Please do not increase the Version according to the date, do only a minor increase, otherwise we might expect trouble, when there are upgrading steps to execute coming from the original code.
2 participants
No description provided.