Open
Conversation
zhdiddl
approved these changes
Dec 1, 2024
| public void logout(Long memberId, HttpServletResponse response) { | ||
| Member member = getMemberById(memberId); | ||
|
|
||
| String key = "refresh_token:" + member.getId(); |
Contributor
There was a problem hiding this comment.
인자로 받은 memberId를 직접 사용하지 않은 이유가 있을까요?
Contributor
Author
There was a problem hiding this comment.
차이는 없는 걸로 알고있습니다. 저는 데이터의 일관성과 엔티티 객체를 통해 데이터에 접근하는 것이 객체 지향 프로그래밍의 원칙에 더 부합하고 알고 있어서 사용하였습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
작업 내역
코드 리팩토링
공동 작업
테스트
다음 진행사항
참고
closes #103