Skip to content

Fix bug introduced in 7.5 with interact menu on self. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Chryssie wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix bug introduced in 7.5 with interact menu on self. #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/extensions.pyproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
<Content Include="sn_better_target_monitor\t\0001-L081.xml" />
<Content Include="sn_better_target_monitor\t\0001.xml" />
<Content Include="sn_mod_support_apis\documentation\Userdata_API.md" />
<Content Include="sn_mod_support_apis\ui\addons\ego_debug\OnlineGetUserItemsPatch.lua" />
<Content Include="sn_sector_travel_rebalance\.gitignore" />
<Content Include="sn_sector_travel_rebalance\content.xml" />
<Content Include="sn_debug_info\change_log.md" />
Expand Down
9 changes: 9 additions & 0 deletions extensions/sn_mod_support_apis/ui/addons/ego_debug/OnlineGetUserItemsPatch.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
local ego_OnlineGetUserItems = OnlineGetUserItems

-- For some reason, this function returns `nil` in certain cases, which causes a bunch of scripts to start breaking when the interact menu code is injected.
-- Inspection of uses of `OnlineGetUserItems` show that no code seems to check for a `nil` value so it's likely not important that it returns `nil`.
function OnlineGetUserItems( ... )
local values = {ego_OnlineGetUserItems(...)}
values[1] = values[1] or {}
return unpack(values)
end
1 change: 1 addition & 0 deletions extensions/sn_mod_support_apis/ui/addons/ego_debug/ui.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<addon name="ego_debug" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../core/coreaddon.xsd">
<environment type="menus">
<file name="debug.lua" />
<file name="OnlineGetUserItemsPatch.lua" />
<file name="Lua_Loader.lua" />
<savedvariable name="__MOD_USERDATA" storage="userdata" />
</environment>
Expand Down