-
-
Notifications
You must be signed in to change notification settings - Fork 87
Feat: Add support for Yiciyuan device #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
weijunji
wants to merge
1
commit into
buttplugio:master
Choose a base branch
from
weijunji:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Buttplug Rust Source Code File - See https://buttplug.io for more info. | ||
| // | ||
| // Copyright 2016-2024 Nonpolynomial Labs LLC. All rights reserved. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The copyright should be 2016-2025 |
||
| // | ||
| // Licensed under the BSD 3-Clause license. See LICENSE file in the project root | ||
| // for full license information. | ||
|
|
||
| use crate::{ | ||
| core::{ | ||
| errors::ButtplugDeviceError, | ||
| message::Endpoint, | ||
| }, | ||
| server::device::{ | ||
| hardware::{HardwareCommand, HardwareWriteCmd}, | ||
| protocol::{generic_protocol_setup, ProtocolHandler}, | ||
| }, | ||
| }; | ||
|
|
||
| generic_protocol_setup!(Yiciyuan, "yiciyuan"); | ||
|
|
||
| #[derive(Default)] | ||
| pub struct Yiciyuan {} | ||
|
|
||
| impl ProtocolHandler for Yiciyuan { | ||
| fn keepalive_strategy(&self) -> super::ProtocolKeepaliveStrategy { | ||
| super::ProtocolKeepaliveStrategy::RepeatLastPacketStrategy | ||
| } | ||
|
|
||
| fn handle_scalar_vibrate_cmd( | ||
| &self, | ||
| _index: u32, | ||
| scalar: u32, | ||
| ) -> Result<Vec<HardwareCommand>, ButtplugDeviceError> { | ||
| let mut cmd = vec![0x35, 0x12, scalar as u8]; | ||
| cmd.resize(16, 0); | ||
| Ok(vec![HardwareWriteCmd::new( | ||
| Endpoint::Tx, | ||
| cmd, | ||
| false, | ||
| ) | ||
| .into()]) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -409,6 +409,7 @@ async fn test_device_protocols_embedded_v2(test_file: &str) { | |
| #[test_case("test_fleshy_thrust_protocol.yaml" ; "Fleshy Thrust Sync Protocol")] | ||
| #[test_case("test_nexus_revo.yaml" ; "Nexus Revo Protocol")] | ||
| #[test_case("test_omobo_protocol.yaml" ; "Omobo Protocol")] | ||
| #[test_case("test_yiciyuan_protocol.yaml" ; "Yiciyuan Protocol")] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the test only uses the vibrate command, it should be in all 4 test suites |
||
| #[tokio::test] | ||
| async fn test_device_protocols_json_v2(test_file: &str) { | ||
| util::device_test::client::client_v2::run_json_test_case(&load_test_case(test_file).await).await; | ||
|
|
||
56 changes: 56 additions & 0 deletions
56
buttplug/tests/util/device_test/device_test_case/test_yiciyuan_protocol.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| devices: | ||
| - identifier: | ||
| name: "YCY-FJB-02" | ||
| expected_name: "YiCiYuan Masturbation Cup 02" | ||
| device_commands: | ||
| # Commands | ||
| - !Messages | ||
| device_index: 0 | ||
| messages: | ||
| - !Vibrate | ||
| - Index: 0 | ||
| Speed: 0.5 | ||
| - !Commands | ||
| device_index: 0 | ||
| commands: | ||
| - !Write | ||
| endpoint: tx | ||
| data: [0x35, 0x12, 0x0A, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] | ||
| write_with_response: false | ||
| - !Messages | ||
| device_index: 0 | ||
| messages: | ||
| - !Vibrate | ||
| - Index: 0 | ||
| Speed: 0.1 | ||
| - !Commands | ||
| device_index: 0 | ||
| commands: | ||
| - !Write | ||
| endpoint: tx | ||
| data: [0x35, 0x12, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] | ||
| write_with_response: false | ||
| - !Messages | ||
| device_index: 0 | ||
| messages: | ||
| - !Vibrate | ||
| - Index: 0 | ||
| Speed: 1.0 | ||
| - !Commands | ||
| device_index: 0 | ||
| commands: | ||
| - !Write | ||
| endpoint: tx | ||
| data: [0x35, 0x12, 0x14, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] | ||
| write_with_response: false | ||
| - !Messages | ||
| device_index: 0 | ||
| messages: | ||
| - !Stop | ||
| - !Commands | ||
| device_index: 0 | ||
| commands: | ||
| - !Write | ||
| endpoint: tx | ||
| data: [0x35, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00] | ||
| write_with_response: false |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that the cups aren't oscillating devices?