refactor(dashboard): migrate 12 bare fetch to apiFetch across 5 files#683
Open
jun261930-tech wants to merge 3 commits into
Open
refactor(dashboard): migrate 12 bare fetch to apiFetch across 5 files#683jun261930-tech wants to merge 3 commits into
jun261930-tech wants to merge 3 commits into
Conversation
P1 of MC code-quality plan (see PLAN.md / PR-api-client.md):
- src/lib/api-client.ts (+120) ApiError + apiFetch<T> wrapper
- src/lib/__tests__/api-client.test.ts (+108) 8 vitest cases (200/401/403/500/network/loop/204/no-redirect)
- src/components/auth-expired-listener.tsx (+30) global mc:auth-expired -> /login redirect
- src/app/layout.tsx (+2) register listener
- eslint.config.mjs (+31) no-restricted-syntax warn for bare fetch('/api/...')
Quality gates passed:
- pnpm vitest run src/lib/__tests__/api-client.test.ts: 8/8 (2.5s)
- pnpm typecheck: 0 error
- pnpm lint: 0 error, 343 warn (~baseline 334 bare fetch + 9 pre-existing)
Out of scope: migrating existing 334 bare fetch sites (P2, separate PR).
P0 verification: playwright captured 19/19 /api/* returning 200 after login,
ruling out backend issue (cookie expired) — see p0-network-evidence.txt.
- Replace loadData() Promise.all 4x fetch → apiFetch<UsageStats|TrendData|...>
- Replace loadSessionCosts() fetch → apiFetch<{ sessions: SessionCostEntry[] }>
- Replace exportData() fetch → apiFetch<Response>({ raw: true })
- Add apiFetch import from '@/lib/api-client'
- Zero new errors: typecheck pass, lint 0 error
Refs: task-11 P2
Files migrated: - dashboard.tsx: 5 calls (status, sessions, claude/sessions, github, hermes) - empty-state-launchpad.tsx: 2 calls (agent-runtimes, capabilities fallback) - sidebar.tsx: 1 call (status overview) - onboarding-checklist-widget.tsx: 3 calls (onboarding read + 2x POST) - security-audit-widget.tsx: 1 call (security-audit) Zero errors: typecheck pass, lint 0 error (325 warnings vs 343 baseline, -18). Refs: task-11 P2.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate dashboard panel (5 files, 12 calls) bare
fetch('/api/...)toapiFetch<T>()from@/lib/api-client.Files Changed
dashboard.tsxempty-state-launchpad.tsxsidebar.tsxonboarding-checklist-widget.tsxsecurity-audit-widget.tsxVerification
pnpm typecheck→ 0 errorpnpm lint→ 0 error, 325 warnings (baseline 343, -18 from this PR)Why this matters
Dashboard is a high-exposure panel with multiple API calls per refresh cycle. Migrating ensures 401 errors are handled uniformly and redirects to /login properly.
Closes: task-11 P2.2