Skip to content

fix(security-scan): handle SecretRef gateway auth credentials #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NePav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security-scan): handle SecretRef gateway auth credentials #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/lib/security-scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,16 @@ function scanOpenClaw(): Category {
} catch { /* skip */ }

const gwAuth = ocConfig?.gateway?.auth
const tokenOk = gwAuth?.mode === 'token' && (gwAuth?.token ?? '').trim().length > 0
const passwordOk = gwAuth?.mode === 'password' && (gwAuth?.password ?? '').trim().length > 0
// gateway.auth.token / .password may be a plain string OR a SecretRef object
// (e.g. {source:"vault", ref:"op://..."} or {source:"file", path:"..."}).
// Calling .trim() on the object crashes. Treat any non-null value as
// "credential configured" — the resolved value is checked at runtime by OpenClaw.
const hasCredential = (value: unknown): boolean => {
if (typeof value === 'string') return value.trim().length > 0
return value != null
}
const tokenOk = gwAuth?.mode === 'token' && hasCredential(gwAuth?.token)
const passwordOk = gwAuth?.mode === 'password' && hasCredential(gwAuth?.password)
const authOk = tokenOk || passwordOk
checks.push({
id: 'gateway_auth',
Expand Down