grpc: emit per-message events for streaming RPCs#315
Open
lucasmeijer wants to merge 1 commit intobuildbarn:mainfrom
Open
grpc: emit per-message events for streaming RPCs#315lucasmeijer wants to merge 1 commit intobuildbarn:mainfrom
lucasmeijer wants to merge 1 commit intobuildbarn:mainfrom
Conversation
|
2856ee8 to
87ba874
Compare
87ba874 to
5ace967
Compare
5ace967 to
206540e
Compare
EdSchouten
reviewed
Mar 5, 2026
| // convert into trace span attributes. The resulting attributes will | ||
| // have "request." prepended to their names. If the RPC is client | ||
| // streaming, the value is extracted from the first message. | ||
| // Names of fields to extract from the first request message of an |
Member
There was a problem hiding this comment.
Shouldn't the word 'first' be removed here? I think the original description was accurate, with the exception of that final sentence.
| // Attributes will not be attached to trace spans if one of the parent | ||
| // messages of the field that is referenced is not set. | ||
| repeated string attributes_from_first_request_message = 1; | ||
| repeated string attributes_from_request_message = 1; |
| // 'attributes_from_request_message'. | ||
| repeated string attributes_from_response_message = 2; | ||
|
|
||
| // Whether to extract attributes from follow-up request and response |
Member
There was a problem hiding this comment.
I'm not too happy with the term 'follow-up'. What are your thoughts on having options like these instead?
// If not set, only extract attributes from the first request message, and
// attach them to the trace span.
//
// If set, extract attributes from all request messages, and emit a per-message
// span event containing those attributes.
bool emit_request_message_events = 3;
// If not set, only extract attributes from the first response message, and [...]
bool emit_response_message_events = 4;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.