Skip to content

Add Buildbarn logo svg #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moroten wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Buildbarn logo svg #178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1cfe44
Add Buildbarn logo svg
moroten Sep 13, 2023
fd73ecb
Integrate logo in otel
moroten Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pkg/logo/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
load("@io_bazel_rules_go//go:def.bzl", "go_library")

# Minify the logo into a favicon.
genrule(
name = "favicon",
srcs = [":buildbarn_logo.svg"],
outs = ["favicon.svg"],
# Remove embedded draw.io content attribute and svg comments.
cmd = "tr -d '\n' < $(location :buildbarn_logo.svg) | sed -e 's/ content=\"[^\"]*\"//' -e 's/<!--[^!]*-->//g' > $@",
)

go_library(
name = "logo",
srcs = ["logo.go"],
embedsrcs = [
"favicon.svg",
],
importpath = "github.com/buildbarn/bb-storage/pkg/logo",
visibility = ["//visibility:public"],
)
21 changes: 21 additions & 0 deletions pkg/logo/buildbarn_logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions pkg/logo/logo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package logo

import (
_ "embed" // For "go:embed".
)

//go:embed favicon.svg
var faviconSvg []byte

// FaviconSvg holds the Buildbarn logo and can be used as favicon in web browsers.
var FaviconSvg = faviconSvg
Copy link
Member

@EdSchouten EdSchouten Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why the indirection? We can't make the go:embed variable public? I think we should also call this FaviconSVG, as in Go they tend to write abbreviations like HTTP, XML, etc. in all caps.