Merged
Conversation
|
This change is necessary to catch up with the API changes introduced in buildbarn/bb-remote-execution#216. It removes any implementations of, and calls to VirtualReadLink(), and uses VirtualGetAttributes(AttributesMaskSymlinkTarget) instead. With this change applied, symlinks created in the virtual file system are always normalized. $ ln -s //////../foo//bar/./baz $ ls -l baz lrwxrwxrwx 9999 nobody nobody 12 Jan 1 2000 baz -> /foo/bar/baz
2056b7c to
8bb84cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This change is necessary to catch up with the API changes introduced in buildbarn/bb-remote-execution#216. It removes any implementations of, and calls to VirtualReadLink(), and uses VirtualGetAttributes(AttributesMaskSymlinkTarget) instead.
With this change applied, symlinks created in the virtual file system are always normalized.