Skip to content

Let symlinks be backed by path.Parser#42

Merged
EdSchouten merged 1 commit intomainfrom
eschouten/20260317-symlink
Mar 19, 2026
Merged

Let symlinks be backed by path.Parser#42
EdSchouten merged 1 commit intomainfrom
eschouten/20260317-symlink

Conversation

@EdSchouten
Copy link
Member

This change is necessary to catch up with the API changes introduced in buildbarn/bb-remote-execution#216. It removes any implementations of, and calls to VirtualReadLink(), and uses VirtualGetAttributes(AttributesMaskSymlinkTarget) instead.

With this change applied, symlinks created in the virtual file system are always normalized.

$ ln -s //////../foo//bar/./baz
$ ls -l baz
lrwxrwxrwx  9999 nobody  nobody  12 Jan  1  2000 baz -> /foo/bar/baz

@aspect-workflows
Copy link

aspect-workflows bot commented Mar 18, 2026

Test

4 test targets passed

Targets
//pkg/blobstore:blobstore_test [k8-fastbuild]                         71ms
//pkg/cas:cas_test [k8-fastbuild]                                     167ms
//pkg/filesystem/virtual:virtual_test [k8-fastbuild]                  205ms
//pkg/outputpathpersistency:outputpathpersistency_test [k8-fastbuild] 189ms

This change is necessary to catch up with the API changes introduced in
buildbarn/bb-remote-execution#216. It removes
any implementations of, and calls to VirtualReadLink(), and uses
VirtualGetAttributes(AttributesMaskSymlinkTarget) instead.

With this change applied, symlinks created in the virtual file system
are always normalized.

    $ ln -s //////../foo//bar/./baz
    $ ls -l baz
    lrwxrwxrwx  9999 nobody  nobody  12 Jan  1  2000 baz -> /foo/bar/baz
@EdSchouten EdSchouten force-pushed the eschouten/20260317-symlink branch from 2056b7c to 8bb84cd Compare March 19, 2026 05:02
@EdSchouten EdSchouten merged commit deed743 into main Mar 19, 2026
3 checks passed
@EdSchouten EdSchouten deleted the eschouten/20260317-symlink branch March 19, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant