fix: guard against empty choices and message=None in make_api_call#43
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty choices and message=None in make_api_call#43qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
client.chat.completions.create() (Groq's OpenAI-compatible API) can return choices=[] on content-policy rejections or provider errors, and choices[0].message=None on filtered responses. Both crash with IndexError/AttributeError inside the retry loop, producing a confusing 'Failed after 3 attempts' message. Explicit guards raise ValueError so the except branch catches a meaningful error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add explicit guards in
make_api_call()before accessingresponse.choices[0].message.contentin both theis_final_answer=Trueandis_final_answer=Falsebranches.Why
client.chat.completions.create()(Groq's OpenAI-compatible API) can return two empty-response shapes:choices = []— on content-policy rejections, rate-limit errors, or provider failureschoices[0].message = None— e.g. when content is filtered, some OpenAI-compatible providers return HTTP 200 with the message field absentBoth crash with
IndexErrororAttributeErrorinside the retry loop. The surroundingexcept Exception as e:catches these crashes but produces a confusing"Failed to generate step after 3 attempts. Error: list index out of range"message, masking the actual cause.With the explicit guards, the
ValueErroris raised before the attribute access, caught by the existing retry logic, and reported accurately.Change
Applied to both the final-answer branch and the step-reasoning branch.
Corpus context
Detected by
pact(llm_response_unguardedmode), a Z3-verified static analyzer for LLM crash vectors. This pattern was found across 13.7k violations in 786 repos.