Add a level value to instrumented spans #8854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
force-pushed
the
etorreborre/feat/telemetry-traces
branch
3 times, most recently
from
74676b9 to
c096702
Compare
| Conflicts: | implementations/rust/ockam/ockam_api/src/orchestrator/subscription.rs
and remove some unused imports
etorreborre
force-pushed
the
etorreborre/feat/telemetry-traces
branch
3 times, most recently
from
be601fb to
69a388a
Compare
rather than getting from the database all the time
etorreborre
force-pushed
the
etorreborre/feat/telemetry-traces
branch
from
69a388a to
d574e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Sets most of the instrumented spans with the level
TRACE. The idea is to leave those spans for a low-level analysis of where time is spent, and reintroduce them at theINFOlevel only once we know that they are useful for high-level observability in a project UI.Adds an attribute to distinguish host user journeys (all commands from a given node) from project user journey (all commands for a given project).
Reworks the spans emitted when a message is sent via a portal:
receive_tcp_message_at_inlet, thenreceive_ockam_message_from_inlet.receive_tcp_message_at_outlet, thenreceive_ockam_message_from_outletAdditionally, node information (node name + node identifier) and project id have been added to all the spans when the information is available:
CliStatehad to be shared with theSpanExporterto collect that information (if available) when spans are being exported.