-
Notifications
You must be signed in to change notification settings - Fork 33
rename MetaData to Metadata #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration/uplift-2025
Are you sure you want to change the base?
Conversation
| When I run "MetadataScenario" with the defaults | ||
| And I wait to receive an error | ||
| And the error is valid for the error reporting API version "4" for the "Bugsnag Java" notifier | ||
| And the event "metaData.Custom.foo" equals "Hello World!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the payload, the casing is still the same ("metaData"), so this shouldn't have changed.
Not sure if the test is case insensitive or if somehow this PR has amended the underlying JSON - it should remain "metaData" to be completely correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed back 👍
26e609b to
2801a66
Compare
This pull request introduces a comprehensive rename and refactor to standardize the terminology from "MetaData" to "Metadata" throughout the codebase. The changes touch on core classes, logback integration, and tests, ensuring consistency in naming and usage. Additionally, related classes and methods have been renamed, and files have been updated to reflect these changes.
Core terminology and class renaming
MetaDatatoMetadata, and updated all usages, including thread-local storage, merging, and access methods inBugsnag,Report, andDiagnostics. [1] [2] [3] [4] [5]metadatainstead ofmetaData(e.g.,mergeMetadata,getMetadata,addThreadMetadata,clearThreadMetadata) across the codebase. [1] [2] [3] [4] [5] [6]Logback integration updates
LogbackMetaData,LogbackMetaDataTab, andLogbackMetaDataKeytoLogbackMetadata,LogbackMetadataTab, andLogbackMetadataKey. Updated all references and usages accordingly. [1] [2] [3] [4] [5] [6] [7] [8]LogbackMetaData.javafile and replaced it withLogbackMetadata.java. [1] [2]Test and documentation updates
Metadatainstead ofMetaData, includingAppenderMetaDataTesttoAppenderMetadataTest, and updated method names and assertions. [1] [2] [3]metadatafor clarity and consistency. [1] [2]Consistency improvements
These changes collectively improve code readability, maintainability, and reduce confusion by unifying the terminology across the entire codebase.