Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only retrieve device logs in e2e tests when DEBUG is set #1718

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Only retrieve device logs in e2e tests when DEBUG is set #1718

merged 1 commit into from
Jan 6, 2025
+11 −9

Conversation

twometresteve
Copy link
Contributor

Goal

Prevent e2e tests from running extremely slowly due to long log retrieval times on macOS.

Testing

Tested locally with and without the DEBUG variable set.

@github-actions GitHub Actions
Copy link

Bugsnag.framework binary size did not change - 669,112 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit 1d2c98f into next Jan 6, 2025
45 checks passed
@twometresteve twometresteve deleted the tms/log-retrieval branch January 6, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twometresteve @kstenerud