Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flake for foregrounding breadcrumb #1659

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

twometresteve
Copy link
Contributor

Goal

Fixes a test flake where we expect a breading for foregrounding the app.

Design

The test would flake heavily because it wasn't giving enough time for the foreground notification to arrive and be processed. This change introduces a new command where we can pause the processing of commands for a set period, giving the notifier time to receive and process the notification.

Testing

Covered by CI and I've run it >20 times locally without failing once.

@twometresteve twometresteve requested a review from kstenerud June 11, 2024 17:09
Copy link

Bugsnag.framework binary size did not change - 718,176 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit ef99aee into next Jun 12, 2024
40 checks passed
@twometresteve twometresteve deleted the tms/flake-fix branch June 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants