Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page header in scroll mode + tts #342

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

teleshoes
Copy link

also fixes #326

@teleshoes teleshoes force-pushed the page_header_in_scroll_mode_tts branch from 9abf330 to 98dea27 Compare April 12, 2023 16:38
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from teleshoes Apr 22, 2023
Repository owner deleted a comment from plotn Apr 22, 2023
@teleshoes
Copy link
Author

teleshoes commented Apr 30, 2023

@buggins @plotn
TL/DR there is no bug here that i am aware of, and this pull request can be merged as-is, without regression, to the best of my knowledge.

this PR fixes a bug (animation in scroll mode) and implements an unexpectedly missing feature (title bar ignored in scroll mode). with this PR, titleBar/pageHeader/pageFooter works consistently and correctly in scroll mode and page mode, at the top or bottom, with or without animation, and in portrait or landscape

before this PR, titleBar was ignored in scroll mode, and animations in scroll mode were buggy.

notes:

  1. you cannot see the scroll-mode page footer (at the bottom) in TTS mode, because the android navigation bar covers it. this is already the case in page mode when you show the android navigation bar. i think the best solution to always show the title bar would be to just hide the navigation bar in TTS, but that is a completely separate issue.
  2. the animation includes the title bar, like it does in page mode. if this is visually unappealing, an alternative can be implemented, in both page and scroll mode, but it is unrelated to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

top+bottom margins ignored in scroll view
1 participant