Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves requests that cannot capture packets for too long #1256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/capture/capture.go
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,10 @@ func http1StartHint(pckt *tcp.Packet) (isRequest, isResponse bool) {
}

func http1EndHint(m *tcp.Message) bool {
if len(m.Packets()) == 0 {
return false
}

if m.MissingChunk() {
return false
}
Expand Down
16 changes: 11 additions & 5 deletions internal/tcp/tcp_message.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ func (parser *MessageParser) wait() {
}

func (parser *MessageParser) parsePacket(pcapPkt *PcapPacket) *Packet {
pckt, err := ParsePacket(pcapPkt.Data, pcapPkt.LType, pcapPkt.LTypeLen, pcapPkt.Ci, false)
pckt, err := ParsePacket(pcapPkt.Data, pcapPkt.LType, pcapPkt.LTypeLen, pcapPkt.Ci, true)
if err != nil {
if _, empty := err.(EmptyPacket); !empty {
stats.Add("packet_error", 1)
Expand Down Expand Up @@ -313,7 +313,7 @@ func containsOrEmpty(element net.IP, ipList []net.IP) bool {
}

func (parser *MessageParser) processPacket(pckt *Packet) {
if pckt == nil {
if pckt == nil || (len(pckt.Payload) == 0 && !pckt.FIN) {
return
}

Expand Down Expand Up @@ -356,14 +356,14 @@ func (parser *MessageParser) processPacket(pckt *Packet) {
}

func (parser *MessageParser) addPacket(m *Message, pckt *Packet) bool {
if !m.add(pckt) {
if !pckt.FIN && len(pckt.Payload) == 0 || (len(pckt.Payload) != 0 && !m.add(pckt)) {
return false
}

// If we are using protocol parsing, like HTTP, depend on its parsing func.
// For the binary procols wait for message to expire
if parser.End != nil {
if parser.End(m) {
if parser.End(m) || pckt.FIN || (pckt.Direction == DirIncoming && pckt.PSH && pckt.ACK) {
parser.Emit(m)
return true
}
Expand Down Expand Up @@ -405,6 +405,10 @@ func (parser *MessageParser) Read() *Message {
func (parser *MessageParser) Emit(m *Message) {
stats.Add("message_count", 1)

if len(m.packets) == 0 {
return
}

delete(parser.m, m.packets[0].MessageID())

parser.messages <- m
Expand All @@ -430,7 +434,9 @@ func (parser *MessageParser) timer(now time.Time) {
if parser.End == nil || parser.allowIncompete {
parser.Emit(m)
}

if len(m.packets) == 0 {
continue
}
delete(parser.m, m.packets[0].MessageID())
}
}
Expand Down
27 changes: 14 additions & 13 deletions internal/tcp/tcp_packet.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,19 @@ calllers must make sure that ParsePacket has'nt returned any error before callin
function.
*/
type Packet struct {
Direction Dir
messageID uint64
SrcIP, DstIP net.IP
Version uint8
SrcPort, DstPort uint16
Ack, Seq uint32
ACK, SYN, FIN, RST bool
Lost uint32
Retry int
CaptureLength int
Timestamp time.Time
Payload []byte
buf []byte
Direction Dir
messageID uint64
SrcIP, DstIP net.IP
Version uint8
SrcPort, DstPort uint16
Ack, Seq uint32
ACK, SYN, FIN, RST, PSH bool
Lost uint32
Retry int
CaptureLength int
Timestamp time.Time
Payload []byte
buf []byte

created time.Time
gc bool
Expand Down Expand Up @@ -204,6 +204,7 @@ func (pckt *Packet) parse(data []byte, lType, lTypeLen int, cp *gopacket.Capture
pckt.FIN = transLayer[13]&0x01 != 0
pckt.SYN = transLayer[13]&0x02 != 0
pckt.RST = transLayer[13]&0x04 != 0
pckt.PSH = transLayer[13]&0x08 != 0
pckt.ACK = transLayer[13]&0x10 != 0
pckt.Lost = uint32(cp.Length - cp.CaptureLength)

Expand Down
Loading