ci(bundle-check): add --all-targets to per-bundle cargo check - #6670
Merged
Conversation
github-actions
Bot
added
ci
bug-ops
enabled auto-merge (squash)
July 28, 2026 00:20
The bundle-check job only compiled lib/bin targets per feature bundle; every job that runs --all-targets always combines session and acp-http together (or uses full), so a narrower bundle like ide was never checked with --all-targets anywhere in CI. Test-only cfg gates narrower than the production code they exercise could ship and pass CI indefinitely, as happened in #6607.
bug-ops
force-pushed
the
fix/6609-ci-bundle-check-all-targets
branch
from
July 28, 2026 00:24
75f3452 to
d6f21c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlonly compiled lib/bin targets per feature bundle viacargo check --features <bundle>(no--all-targets), so test-module compilation was never verified per-bundle.--all-targets(lint-clippy, msrv, release-build, postgres/sqlite parity) always combines feature strings that enable bothsessionandacp-httptogether, or usesfull, so a narrower bundle likeidewas never checked with--all-targetsin isolation.#[cfg(...)]gate is narrower than the production code it calls ship and pass CI indefinitely, as happened with build_combined_deps_wires_equivalent_security_pipeline_from_config test-only compile failure under --features ide --all-targets #6607 (fixed in fix(acp): align test cfg gate with build_combined_deps' own feature gate #6608).--all-targetsto the existing per-bundlecargo checkstep and bumps the job timeout 10 -> 15 minutes to account for compiling test/bench/example targets per bundle.ci-non-linux.ymlhas no bundle-check job, confirmed directly, left untouched.Closes #6609
Test plan
fy lint .github/workflows/ci.yml— 0 errors (30 pre-existing warnings, none on changed lines)gitleaks protect --staged— no leaks.github/workflows/ci.ymlandCHANGELOG.md, nosrc/*.rstouched--all-targetsstep for theidebundle (and all other bundles) for the first time