test(orchestration): add direct SC-4/SC-9 assertions for Mode-1 recovery - #6317
Merged
Merged
Conversation
bug-ops
enabled auto-merge (squash)
July 16, 2026 18:08
Two spec-075 §7 success criteria were only transitively covered: SC-4 (a recovered node's synthetic TaskResult reaching build_task_prompt for downstream dependents) and SC-9 (a recovery-derived Completed task counted in tasks_completed). Add direct tests for both, deferred from PR #6243/#6265 to avoid scope creep. Closes #6301
bug-ops
force-pushed
the
feat/issue-6301/orchestration-recovered-node
branch
from
July 16, 2026 18:24
a7c60d0 to
2ec352e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_build_prompt_includes_mode1_recovered_state_injection,zeph-orchestration): drives Mode-1 recovery end-to-end (propagate_failure→try_recover) and asserts the injectedstate_injectionvalue actually reachesbuild_task_prompt()for a downstream dependent, without leaking the internal__recovery__completion marker.finalize_plan_execution_recovery_derived_task_counted_in_tasks_completed,zeph-core): asserts a__recovery__-derivedCompletedtask is counted byfinalize_plan_completed's generic, status-basedtasks_completedcounter, with a siblingFailedtask confirmed excluded for real contrast.Closes #6301
Test plan
cargo nextest run -p zeph-orchestration --features llm-planning -E 'test(test_build_prompt_includes_mode1_recovered_state_injection)'cargo nextest run -p zeph-core --features scheduler -E 'test(finalize_plan_execution_recovery_derived_task_counted_in_tasks_completed)'cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins— 13812 passed, 0 failedRUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"gitleaks protect --staged --no-banner --redact