Skip to content

test(orchestration): add direct SC-4/SC-9 assertions for Mode-1 recovery - #6317

Merged
bug-ops merged 1 commit into
mainfrom
feat/issue-6301/orchestration-recovered-node
Jul 16, 2026
Merged

test(orchestration): add direct SC-4/SC-9 assertions for Mode-1 recovery#6317
bug-ops merged 1 commit into
mainfrom
feat/issue-6301/orchestration-recovered-node

Conversation

@bug-ops

@bug-ops bug-ops commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds two direct unit tests closing a transitive-only coverage gap for spec-075 §7 success criteria SC-4 and SC-9, flagged during review of Implement: orchestration node control parity (per-task run_timeout + Mode-1 recovery) #6243/orchestration: /plan confirm gives no user-visible signal when verification judges plan output incomplete #6265 and deliberately deferred to avoid scope creep.
  • SC-4 (test_build_prompt_includes_mode1_recovered_state_injection, zeph-orchestration): drives Mode-1 recovery end-to-end (propagate_failuretry_recover) and asserts the injected state_injection value actually reaches build_task_prompt() for a downstream dependent, without leaking the internal __recovery__ completion marker.
  • SC-9 (finalize_plan_execution_recovery_derived_task_counted_in_tasks_completed, zeph-core): asserts a __recovery__-derived Completed task is counted by finalize_plan_completed's generic, status-based tasks_completed counter, with a sibling Failed task confirmed excluded for real contrast.
  • No production code changes — both mechanisms already behaved correctly; this closes the direct-assertion gap only.

Closes #6301

Test plan

  • cargo nextest run -p zeph-orchestration --features llm-planning -E 'test(test_build_prompt_includes_mode1_recovered_state_injection)'
  • cargo nextest run -p zeph-core --features scheduler -E 'test(finalize_plan_execution_recovery_derived_task_counted_in_tasks_completed)'
  • cargo +nightly fmt --check
  • cargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warnings
  • cargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins — 13812 passed, 0 failed
  • RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"
  • gitleaks protect --staged --no-banner --redact

@github-actions github-actions Bot added documentation Improvements or additions to documentation rust Rust code changes core zeph-core crate tests Test-related changes size/M Medium PR (51-200 lines) labels Jul 16, 2026
@bug-ops
bug-ops enabled auto-merge (squash) July 16, 2026 18:08
Two spec-075 §7 success criteria were only transitively covered:
SC-4 (a recovered node's synthetic TaskResult reaching build_task_prompt
for downstream dependents) and SC-9 (a recovery-derived Completed task
counted in tasks_completed). Add direct tests for both, deferred from
PR #6243/#6265 to avoid scope creep.

Closes #6301
@bug-ops
bug-ops force-pushed the feat/issue-6301/orchestration-recovered-node branch from a7c60d0 to 2ec352e Compare July 16, 2026 18:24
@github-actions github-actions Bot added tests Test-related changes and removed tests Test-related changes labels Jul 16, 2026
@bug-ops
bug-ops merged commit 0dbe9ec into main Jul 16, 2026
43 checks passed
@bug-ops
bug-ops deleted the feat/issue-6301/orchestration-recovered-node branch July 16, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core zeph-core crate documentation Improvements or additions to documentation rust Rust code changes size/M Medium PR (51-200 lines) tests Test-related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

orchestration: recovered-node completion lacks direct assertion in build_task_prompt/metrics paths (SC-4/SC-9)

1 participant