Repository navigation
Replace rewrite_imports with map_imports - #98
Merged
Merged
Conversation
| return None | ||
|
|
||
|
|
||
| def _glob_to_regex(pattern: str) -> re.Pattern[str]: |
There was a problem hiding this comment.
any reason for not using https://docs.python.org/3/library/glob.html#glob.translate or https://docs.python.org/3/library/fnmatch.html#fnmatch.translate ?
Collaborator
Author
There was a problem hiding this comment.
Wish we could! But glob.translate is from Python 3.13, several versions above our floor, and fnmatch is only single-level * support, not recursive **
ajeetdsouza
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically bufbuild/protobuf-es#1528 for Python.
Since we didn't have rewrite_imports here for a while I think it's ok to replace it sooner than later.