Repository navigation
Conversation
…llocation-budget
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve safety for protobuf users, including when they use RPC frameworks like connect, we are implementing allocation budgets for parsing. Large schemas can have many fields allocated per message, and for a language like Python where the memory overhead per type is high, this can quickly balloon - the unit test case demonstrates it with
FileDescriptorProto, which can amplify from 2-3 bytes to 700 bytes.This adds a public API, I called it
allocation_limit, the approximate bytes to cap allocation at. We want to make sure to use the same name in protobuf-es, let me know if any preference.Some notes
Most importantly, all approximations are at most 2-3x (strings), not the potential 300x of a large schema in a message.
Incrementing and checking a int is almost no overhead and noise in benchmarks, both native and pure python.