Repository navigation
Add rewrite_imports option - #70
Merged
Merged
Conversation
Member
|
I'm not super happy with the option, but it solves actual practical problems, see bufbuild/protobuf-es#1203 and bufbuild/protovalidate-es#151. If you have a good idea how to simplify it, let me know. |
Collaborator
Author
|
Yeah those issues also made me think a last-minute escape hatch is useful regardless of BSR integration or such. So if it makes sense to go with it I'd like to get it in. Thanks for checking it! |
…ewrite-imports
ajeetdsouza
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
rewrite_optionsoption similar to protobuf-es seems worth supporting as an escape hatch for packaging deviations for external dependencies. It's nice to be fully implementable in the plugin, though I am also interested in an option with better UX that would likely need some changes to Buf or other components. What do you think?Fixes #65
Closes #15