Repository navigation
Cache all versions by source - #2779
Merged
Merged
Conversation
The fix to set `max_version` for connectrpc/gosimple didn't work completely since the latest version is cached per source, and connectrpc/go and connectrpc/gosimple use the same GitHub source. Update the fetcher to fetch all versions from a source and cache them. Then add a method to calculate the latest version for a source, accounting for `max_version` and `ignore_versions`. This allows multiple plugins to share a common source for version information but differ in their allowed versions. Fixes #2778.
pkwarren
commented
Oct 8, 2026
| require.Contains(t, pending, pluginDir) | ||
| want := "v2.0.0" | ||
| if config.Source.MaxVersion != "" { | ||
| want = "v1.1.0" |
Member
Author
There was a problem hiding this comment.
This test exercises the issue with connectrpc/go and connectrpc/gosimple.
| return "", false | ||
| } | ||
| if semver.Prerelease(version) != "" { | ||
| if semver.Prerelease(version) != "" || semver.Build(version) != "" { |
Member
Author
There was a problem hiding this comment.
Plugins today don't really support this in our versioning scheme and none are dependent on it so just filtering these out.
oliversun9
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix to set
max_versionfor connectrpc/gosimple didn't work completely since the latest version is cached per source, and connectrpc/go and connectrpc/gosimple use the same GitHub source.Update the fetcher to fetch all versions from a source and cache them. Then add a method to calculate the latest version for a source, accounting for
max_versionandignore_versions. This allows multiple plugins to share a common source for version information but differ in their allowed versions.Fixes #2778.