Repository navigation
Fix deadlock with inspect code - #535
Merged
Merged
Conversation
The buf plugin previously ran inspections through inspect code under a read lock (held by the platform) and performed `WriteAction.computeAndWait` which couldn't complete while the read lock was held. Update the inspection to record files to check in `checkFile` and then run inspections once per Buf context root in `inspectionFinished` (which is called without a read lock). Adds a test which replicated the deadlock and now passes. Fixes #534.
pkwarren
commented
Oct 9, 2026
| val isBufDocument = { document: Document -> fileDocumentManager.getFile(document)?.isBufFile() == true } | ||
| if (fileDocumentManager.unsavedDocuments.any(isBufDocument)) { | ||
| WriteAction.computeAndWait<Unit, Throwable> { | ||
| fileDocumentManager.saveDocuments(isBufDocument) |
Member
Author
There was a problem hiding this comment.
We still save files here since the buf CLI runs against files on disk but we only do so if .proto files or buf config files change instead of if any files changed.
Contributor
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2026.2.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
oliversun9
approved these changes
Oct 9, 2026
emcfarlane
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buf plugin previously ran inspections through inspect code under a read lock (held by the platform) and performed
WriteAction.computeAndWaitwhich couldn't complete while the read lock was held.Update the inspection to record files to check in
checkFileand then run inspections once per Buf context root ininspectionFinished(which is called without a read lock).Adds a test which replicated the deadlock and now passes.
Fixes #534.