Repository navigation
Update cel-spec and cel-go dependencies - #229
Merged
Merged
Conversation
timostamm
reviewed
Nov 5, 2025
added 5 commits
November 5, 2025 14:07
Author
|
Per offline recommendations, rebased onto #230 |
timostamm
reviewed
Nov 6, 2025
Comment on lines
+292
to
+298
| return new Intl.NumberFormat("en-US", { | ||
| maximumFractionDigits: precision, | ||
| minimumFractionDigits: precision, | ||
| notation: "standard", | ||
| roundingMode: "halfEven", | ||
| useGrouping: false, | ||
| }).format(val); |
Member
There was a problem hiding this comment.
roundingMode is an ES2023 feature. I expect that environments that don't implement the option will ignore it, which results in different behavior for certain CEL floats converted to string.
If consistent behavior of this specific property is important when targeting lower environments, a polyfill must be provided.
timostamm
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #230 first!