Repository navigation
Conversation
timostamm
reviewed
Oct 23, 2025
Comment on lines
+83
to
+103
| function toJsonCompatibleValue( | ||
| value: CEL.CelValue, | ||
| ): ReturnType<(typeof JSON)["parse"]> { | ||
| if (CEL.isCelMap(value)) { | ||
| return Object.fromEntries( | ||
| [...value.entries()].map( | ||
| ([k, v]): [string, ReturnType<(typeof JSON)["parse"]>] => [ | ||
| k.toString(), | ||
| toJsonCompatibleValue(v), | ||
| ], | ||
| ), | ||
| ); | ||
| } | ||
|
|
||
| if (CEL.isCelList(value)) { | ||
| return [...value].map( | ||
| (v): ReturnType<(typeof JSON)["parse"]> => toJsonCompatibleValue(v), | ||
| ); | ||
| } | ||
|
|
||
| return value; |
Member
There was a problem hiding this comment.
I think we also need to handle CelUint, bigint, Uint8Array, maybe also CelType and ReflectMessage: https://github.com/bufbuild/cel-es/tree/main/packages/cel#types
This could be a replacer: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#the_replacer_parameter
YAML stringify supports it too.
Or it could be a function in @bufbuild/cel - but then we need to be very certain about it.
Or we could just have a comment here to clarify that this function doesn't handle all possible CEL values.
added 15 commits
November 11, 2025 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.