Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting this pull request, please go through the checklist below.
If you're doing something in the checklist, put an
xinside[ ]so that- [ ]becomes- [x]DESCRIPTION
While following the tutorial, I noticed that the contributors.js file is not included in the scripts directory. This caused some confusion because the instructions ask contributors to add their card file name there, but beginners won’t find the file.
Notes to Reviewers
1.New contributors may get stuck when they can’t locate contributors.js.
2.A possible solution is to either include a starter contributors.js file in the repo or update the documentation to explain that contributors should create it manually if it’s missing.