Reapply: derive launch args for kimi-native and antigravity-native sub-agents - #8
Open
btli wants to merge 9 commits into
Open
Reapply: derive launch args for kimi-native and antigravity-native sub-agents#8btli wants to merge 9 commits into
btli wants to merge 9 commits into
Conversation
…e sub-agents Named sub-agent workers on the kimi-native and antigravity-native harnesses launched with no autonomy flag, so every risky tool call parked on a web approval card no headless pane can answer. _derive_terminal_launch_args_from_spec only knew claude/codex/cursor and fell through to None for both harnesses. - kimi-native: executor.config yolo: true -> ["--yolo"] (kimi's auto-approve-tools flag, matching codex/cursor semantics; --auto full autonomy deliberately not mapped). Opt-in: absent/false unchanged. - antigravity-native: executor.config permission_mode: bypassPermissions -> ["--dangerously-skip-permissions"], agy's only pre-emptive permission control. Other/absent modes unchanged. The runner spawn path already forwards snapshot terminal_launch_args verbatim into the agy argv (build_agy_launch extra_args), now pinned by a spawn-path test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Bryan Li <bryan.li@gmail.com>
Tribunal round-1 findings on the kimi-native / antigravity-native launch-arg derivation: - Verified the spec parser stringifies scalar executor.config values (spec/parser.py str(v) coercion), so the bool arm serves programmatically built specs (config is dict[str, Any]); kept it, aligned the comment, and added bool True/False test rows. - Documented the value-matching policy: flag keys (yolo) accept bool or case-insensitive true/false strings (mirroring _spec_config_flag_explicitly_disabled); mode keys (permission_mode) match exactly, mirroring the runner's should_skip_permissions comparison. - Debug-log a present-but-unrecognized yolo / permission_mode value instead of silently no-opping. - Parametrized boundary tests pinning accepted-vs-rejected spellings for both branches. - Pinned build_agy_launch's existing skip-flag dedup for the double-source case (permission_mode=bypassPermissions + the flag already in extra_args -> exactly one flag). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Bryan Li <bryan.li@gmail.com>
fix(server): derive launch args for kimi-native and antigravity-native sub-agents
This reverts commit bb1db02. Signed-off-by: Bryan Li <bryan.li@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies #7 (reverted in bb1db02 during incident backout). The incident root cause was NOT this change: every runner (all harnesses) died at boot with ModuleNotFoundError: prompt_toolkit, because the editable uv tool install failed to resolve workspace-SDK dependencies (sdks/ui declares prompt_toolkit>=3). The reinstall now carries the missing dep explicitly and imports are verified before host restart.
🤖 Generated with Claude Code